Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job
Date
Msg-id CANxoLDdZo5oJFs_vUcGUsO+sd1jMNFS5J8FzLhbODqX3UoED_A@mail.gmail.com
Whole thread Raw
In response to Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Tue, Mar 31, 2020 at 2:21 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Rahul,

The patch looks good to me. It can be committed.

On Tue, Mar 31, 2020 at 2:15 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi,

Ignore the previous mail, find the latest patch attached.

On Tue, Mar 31, 2020 at 2:14 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Thanks Aditya for reviewing.

I have made the relevant changes, please find the inclusive patch attached here.

--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.

On Tue, Mar 31, 2020 at 11:48 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Rahul,

The patch looks good to me. But can you please remove the placeholder in the properties tab. It looks like some value is set, but I kept it empty. Refer below screenshot:

image.png

On Tue, Mar 31, 2020 at 11:24 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya

Can you please review it.

On Mon, Mar 30, 2020 at 5:57 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please find the patch for pgagents schedules dates issue.

--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Ensure that the start and end date should be deleted
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin][RM5268] Wrong SQL generated when we update FTSConfiguration and FTS Dictionary