Home > mailing lists

Re: [RM- 4575] RE_SQL for Schema - Mailing list pgadmin-hackers

From	Akshay Joshi
Subject	Re: [RM- 4575] RE_SQL for Schema
Date	August 8, 2019 16:38:24
Msg-id	CANxoLDdZHmqPozanHujQtcdMdxhiwh-s1pguReVaq2jLYSv8HA@mail.gmail.com Whole thread Raw
In response to	[RM- 4575] RE_SQL for Schema (Vishal Sawale <vishal.sawale@enterprisedb.com>)
List	pgadmin-hackers

Hi Vishal

Following are my review comments:

Test cases for Schemas are not executing at all, we need to change the logic.
test.json file is not aligned properly.
Don't specify the namespaceowner/grantee/grantor as a hardcoded value to 'enterprisedb'.
Don't specify the hardcode value for "oid": 40970.

On Thu, Aug 8, 2019 at 4:23 PM Vishal Sawale <vishal.sawale@enterprisedb.com> wrote:

Hi Hackers,

PFA the patch for RE-SQL test cases for Schema node. Please review.

Regards,
Vishal

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

pgadmin-hackers by date:

From: Aditya Toshniwal
Date: 08 August 2019, 16:17:40
Subject: [pgAdmin] Remove hard-source-webpack-plugin

From: Dave Page
Date: 08 August 2019, 17:07:14
Subject: pgAdmin 4 commit: Add support for OpenSSL 1.1.1 to the Windows installe