Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE statements - Mailing list pgsql-hackers

From Akshay Joshi
Subject Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE statements
Date
Msg-id CANxoLDdSqqk8hg1m2=-6dv=23ZpRkfEXkZWpGtQT=aTJ0088yg@mail.gmail.com
Whole thread
Responses Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE statements
List pgsql-hackers


On Mon, Jun 22, 2026 at 7:30 PM Chao Li <li.evan.chao@gmail.com> wrote:


> On Jun 22, 2026, at 20:40, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
>
> You're right, and thanks for spotting this. The existing pattern in pg_proc.dat for variadic-text functions (e.g., jsonb_delete, json_extract_path) uses _text at the variadic position in both proargtypes and proallargtypes, with provariadic => 'text'. That is the convention documented by the sanity check in src/test/regress/sql/opr_sanity.sql.
>
> The same issue applies to pg_get_role_ddl, pg_get_tablespace_ddl (both variants), and pg_get_database_ddl, but that will require a separate patch.
>

Thanks for confirming. Then I will file a patch tomorrow to fix those.

   I started working on it, but if you want to take the lead, just let me know and I won't send my version over 

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/




pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: RFC: Logging plan of the running query
Next
From: Renaud Métrich
Date:
Subject: Re: [PATCH v3] Add ssl_cert_files/ssl_key_files for multi-certificate support