No Dave, the Makefile target was not added. Have attached the patch for same, please do let me know if needed anything else. @Akshay will you be able to review quickly on this ? Thank you :) Pramod AhireSoftware Engineer C: +91-020-66449600/601D: +91-9028697679edbpostgres.com From: Dave Page <dpage@pgadmin.org>Date: Friday, 7 August 2020 at 2:16 PMTo: Pramod Ahire <pramod.ahire@enterprisedb.com>Cc: Akshay Joshi <akshay.joshi@enterprisedb.com>, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>Subject: Re: Code coverage report generation for JS files Was a Makefile target added? Maybe "make coverage"... On Fri, Aug 7, 2020 at 8:10 AM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:Thank you :) Pramod AhireSoftware Engineer C: +91-020-66449600/601D: +91-9028697679edbpostgres.com From: Akshay Joshi <akshay.joshi@enterprisedb.com>Date: Friday, 7 August 2020 at 12:38 PMTo: Pramod Ahire <pramod.ahire@enterprisedb.com>Cc: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>, Dave Page <dpage@pgadmin.org>Subject: Re: Code coverage report generation for JS files Thanks, patch applied. -- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEDB: http://www.enterprisedb.com
No Dave, the Makefile target was not added.
Have attached the patch for same, please do let me know if needed anything else.
@Akshay will you be able to review quickly on this ?
Thank you :)
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
edbpostgres.com
From: Dave Page <dpage@pgadmin.org>Date: Friday, 7 August 2020 at 2:16 PMTo: Pramod Ahire <pramod.ahire@enterprisedb.com>Cc: Akshay Joshi <akshay.joshi@enterprisedb.com>, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>Subject: Re: Code coverage report generation for JS files
Was a Makefile target added? Maybe "make coverage"...
On Fri, Aug 7, 2020 at 8:10 AM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:
Thank you :) Pramod AhireSoftware Engineer C: +91-020-66449600/601D: +91-9028697679edbpostgres.com From: Akshay Joshi <akshay.joshi@enterprisedb.com>Date: Friday, 7 August 2020 at 12:38 PMTo: Pramod Ahire <pramod.ahire@enterprisedb.com>Cc: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>, Dave Page <dpage@pgadmin.org>Subject: Re: Code coverage report generation for JS files Thanks, patch applied.
From: Akshay Joshi <akshay.joshi@enterprisedb.com>Date: Friday, 7 August 2020 at 12:38 PMTo: Pramod Ahire <pramod.ahire@enterprisedb.com>Cc: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>, pgadmin-hackers <pgadmin-hackers@postgresql.org>, Dave Page <dpage@pgadmin.org>Subject: Re: Code coverage report generation for JS files
Thanks, patch applied.
--
Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEDB: http://www.enterprisedb.com
pgadmin-hackers by date:
Соглашаюсь с условиями обработки персональных данных