Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][PATCH] To fix dialog help in browser tab/window - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin4][PATCH] To fix dialog help in browser tab/window
Date
Msg-id CANxoLDci4Hx4zu-E35UM-R0eQ_hB2X=b+Zy7WcyNu340XBT+4w@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][PATCH] To fix dialog help in browser tab/window  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks patch applied.

On Thu, Mar 30, 2017 at 7:54 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue where "Dialog Help" was broken in case where query tool/Debugger opens in new browser tab.
RM#2310

Note:
Object help might not work as well when used in new browser tab but for that we might need to find a way to pass node & server information in new browser tab so that we can able to create proper url for given/selected object which requires some time and fortunately we not using Object help button in query tool or debugger at present, meanwhile this patch will fix the issue for dialog help button only.


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Dialog Help was broken in case where querytool/Debug
Next
From: Harshal Dhumal
Date:
Subject: [pgAdmin4] [RM2305] unable to set comment with non ascii characterson objects.