Request a Demo
Home   >   mailing lists

Re: [PATCH] Add pg_get_database_ddl() function to reconstruct CREATE DATABASE statement - Mailing list pgsql-hackers

From Akshay Joshi
Subject Re: [PATCH] Add pg_get_database_ddl() function to reconstruct CREATE DATABASE statement
Date
Msg-id CANxoLDcW2iyOq8JJYQXkzXkK6PtQX-z7Hxe=Ri3nQJX6AaPLjw@mail.gmail.com
Whole thread
In response to Re: [PATCH] Add pg_get_database_ddl() function to reconstruct CREATE DATABASE statement  (Álvaro Herrera <alvherre@kurilemu.de>)
List pgsql-hackers
Tree view

Thanks for the review, Japin. I’ve addressed all of your comments. I also added a check to throw an error if an option appears more than once.

Attached is the v10 patch, now ready for further review.


On Wed, Mar 4, 2026 at 3:15 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
On 2026-Mar-04, Japin Li wrote:

> After playing with this patch, I’m seeing the following output:
>
> # select pg_get_database_ddl('postgres'::regdatabase, 'defaults', true, 'pretty', true, 'pretty', false);

I think this should throw an error that 'pretty' was contradictorily
specified twice.  (Maybe also an error if an option appears twice,
period.)

--
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
Attachment

pgsql-hackers by date:

Previous
From: Amul Sul
Date:
Subject: Re: pg_waldump: support decoding of WAL inside tarfile
Next
From: Eugeny Goryachev
Date:
Subject: [PATCH] intarray: prevent crash in _int_matchsel on invalid query_int input