Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable tolaunch query tool and debugger in new browser tab - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable tolaunch query tool and debugger in new browser tab
Date
Msg-id CANxoLDcQV7socMUmvXxL0V-E=W9LUoYzmgoMRb-s1FyYtOzrXw@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable tolaunch query tool and debugger in new browser tab  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable tolaunch query tool and debugger in new browser tab
List pgadmin-hackers
Thanks patch applied.

On Mon, May 8, 2017 at 3:21 PM, Dave Page <dpage@pgadmin.org> wrote:
Akshay, could you review this please?

Thanks.

On Fri, May 5, 2017 at 11:53 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi,

Please find attached patch file with the fix of RM #2328 - [Runtime]: Unable to launch query tool and debugger in new browser tab.

I have used Qt 5.8 with webkit mentioned in below URL.



As there was a bug in QWebKit regarding "unload" event. We have raised and also they have provided patch file to fix this issue. I have applied the patch in linux and compile the webkit and tested the attached patch with compiled webkit which is now working fine.

Below is the link for reference regarding unload issue. They have provided test webkit release for Mac in below URL but for other platform we need to apply the patch and compile the webkit until they provide webkit-releases for all platforms.


Do review it and let me know in case of any issue.

Thanks,
Neel Patel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: [pgadmin-hackers] pgAdmin 4 commit: Fixes #2328
Next
From: Dave Page
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable tolaunch query tool and debugger in new browser tab