Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: SqlFieldControl enhancements - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin4][Patch]: SqlFieldControl enhancements
Date
Msg-id CANxoLDc=h0d3PFwiqtL2KKBZ=GbOyUw6T=jjCuGBDMg5Fv8V5w@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch]: SqlFieldControl enhancements  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks, patch applied.

On Tue, Aug 23, 2016 at 12:13 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi

Following are the enhancements:
1) Disable cursor mode if editor is disabled.
if cursor is enabled. on pressing keys, a false event is generated and on validating models it causes Save button to enable.
2) If editor is disabled, set dark background colour.
3) CodeMirror corners seems to cut around. CodeMirror z-index is greater than pgadmin-control class which causing issue. it is fixed.
4) CodeMirror not taking full height. set line-height css property to fix the issue.


Please find attached patch and review.


Thanks,
Surinder Kumar


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: SqlFieldControl enhancements
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Set break point option should present in pgAdmin4 for