Home > mailing lists

Re: [pgAdmin][patch] Theme component usage fix - Mailing list pgadmin-hackers

From	Akshay Joshi
Subject	Re: [pgAdmin][patch] Theme component usage fix
Date	June 30, 2022 11:56:28
Msg-id	CANxoLDc1w+Fis0TKXCMsza7jwWZoW62yryP+oUOtepQ50ooXkQ@mail.gmail.com Whole thread Raw
In response to	Re: [pgAdmin][patch] Theme component usage fix (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Responses	Re: [pgAdmin][patch] Theme component usage fix (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List	pgadmin-hackers

Tree view

Hi Aditya

Please fix the linter error and send the patch again.

On Thu, Jun 30, 2022 at 2:12 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi,

Attached is the rebased patch.

On Thu, Jun 30, 2022 at 2:06 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya

Can you please rebase and send the patch again.

On Thu, Jun 30, 2022 at 1:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch fixes the usage of the Theme component.
Please note, a component should not be wrapped in multiple Theme components as it will create styling issues.

--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"

--
Akshay Joshi
Principal Software Architect
+91 9767888246
www.enterprisedb.com

--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"