On Thu, 2 Jul 2026 at 04:53, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Only trivial comments for v16*
>
> //////
> v16-0001
> //////
>
> ======
> src/bin/pg_dump/pg_dump.c
>
> getPublictions:
>
> 1.
> /*
> - * Get the list of tables for publications specified in the EXCEPT
> - * TABLE clause.
> + * Get the list of tables and sequences for publications specified in
> + * the EXCEPT clause.
> *
>
> Perhaps this comment should say that EXCEPT (TABLE ...) is introduced
> in PG19, and EXCEPT (SEQUENCE ...) is introduced in PG20. That way
> there are no surprises about the different version checks that follow.
>
> ======
> src/test/subscription/t/037_except.pl
>
> 2.
> +# Check the initial data on subscriber
> +$result = $node_subscriber->safe_psql('postgres',
> + "SELECT last_value, is_called FROM seq_excluded_in_pub1");
> +is($result, '1|f', 'sequences in EXCEPT list is excluded');
>
> typo: plural. Should be "sequences in the EXCEPT list are excluded"
>
> //////
> v16-0002
> //////
>
> ======
> src/test/subscription/t/037_except.pl
>
> 1.
> +is($result, '1|f', 'sequences in EXCEPT list is excluded');
>
> typo: plural. Should be "sequences in the EXCEPT list are excluded"
>
Thanks Peter for the review. I have addressed the comments.
Also the patch needed a rebase after the recent commits.
Please find the updated v17 patch attached.
Thanks,
Shlok Kyal
