Re: psql: Add command to use extended query protocol - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: psql: Add command to use extended query protocol
Date
Msg-id CANbhV-Gv8s4n+hBMa++DmCeEuY30v0WbAzLcBTjYhK=47vvuDQ@mail.gmail.com
Whole thread Raw
In response to Re: psql: Add command to use extended query protocol  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
On Tue, 1 Nov 2022 at 20:48, Peter Eisentraut
<peter.eisentraut@enterprisedb.com> wrote:
>
> On 01.11.22 10:10, Simon Riggs wrote:
> > On Fri, 28 Oct 2022 at 07:53, Peter Eisentraut
> > <peter.eisentraut@enterprisedb.com> wrote:
> >>
> >> This adds a new psql command \gp that works like \g (or semicolon) but
> >> uses the extended query protocol.  Parameters can also be passed, like
> >>
> >>       SELECT $1, $2 \gp 'foo' 'bar'
> >
> > +1 for the concept. The patch looks simple and complete.
> >
> > I find it strange to use it the way you have shown above, i.e. \gp on
> > same line after a query.
>
> That's how all the "\g" commands work.

Yes, I see that, but it also works exactly the way I said also.

i.e.
SELECT 'foo'
\g

is the same thing as

SELECT 'foo' \g

But there are no examples in the docs of the latter usage, and so it
is a surprise to me and probably to others also

> > ...since if we used this in a script, it would be used like this, I think...
> >
> >    SELECT $1, $2
> >    \gp 'foo' 'bar'
> >    \gp 'bar' 'baz'
> >    ...
>
> Interesting, but I think for that we should use named prepared
> statements, so that would be a separate "\gsomething" command in psql, like
>
>      SELECT $1, $2 \gprep p1
>      \grun p1 'foo' 'bar'
>      \grun p1 'bar' 'baz'

Not sure I understand this... you seem to be arguing against your own
patch?? I quite liked the way you had it, I'm just asking for the docs
to put the \gp on the following line.

-- 
Simon Riggs                http://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Direct I/O
Next
From: Jacob Champion
Date:
Subject: Re: User functions for building SCRAM secrets