Re: Hash index build performance tweak from sorting - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Hash index build performance tweak from sorting
Date
Msg-id CANbhV-Ea422yDfj8McFRiGbpZxoU54Q+Xs0i2zN7Tmb=wQorzQ@mail.gmail.com
Whole thread Raw
In response to Re: Hash index build performance tweak from sorting  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Hash index build performance tweak from sorting
List pgsql-hackers
On Wed, 23 Nov 2022 at 13:04, David Rowley <dgrowleyml@gmail.com> wrote:

> After getting rid of the  HashInsertState code and just adding bool
> sorted to _hash_doinsert() and _hash_pgaddtup(), the resulting patch
> is much more simple:

Seems good to me and I wouldn't argue with any of your comments.

> and v4 includes 7 extra lines in hashinsert.c for the Assert() I
> mentioned in my previous email plus a bunch of extra comments.

Oh, I did already include that in v3 as requested.

> I'd rather see this solved like v4 is doing it.

Please do. No further comments. Thanks for your help

-- 
Simon Riggs                http://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Prefetch the next tuple's memory during seqscans
Next
From: Amit Kapila
Date:
Subject: Re: Perform streaming logical transactions by background workers and parallel apply