Re: More speedups for tuple deformation - Mailing list pgsql-hackers

From John Naylor
Subject Re: More speedups for tuple deformation
Date
Msg-id CANWCAZbpEb3LgBLoUU3kfKMvHRG=-ziLu1Z8VP76jry2Ky_VFg@mail.gmail.com
Whole thread
In response to Re: More speedups for tuple deformation  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
On Wed, Feb 25, 2026 at 7:40 AM David Rowley <dgrowleyml@gmail.com> wrote:
> On Wed, 25 Feb 2026 at 07:33, Zsolt Parragi <zsolt.parragi@percona.com> wrote:

> > Won't this mix up column numbers on big-endian systems?
>
> Yes, I believe you're right. I've added the following before the memcpy().
>
> #ifdef WORDS_BIGENDIAN
>
>     /*
>      * Fix byte order on big-endian machines before copying to the array.
>      */
>     isnull_8 = pg_bswap64(isnull_8);
> #endif

I confirmed regression tests bail out early on a big-endian machine
with v9 and pass with v10.

--
John Naylor
Amazon Web Services



pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: amcheck: fix bug of missing corruption in allequalimage validation
Next
From: vignesh C
Date:
Subject: Re: Skipping schema changes in publication