On Thu, Apr 2, 2026 at 3:50 PM Lukas Fittl <lukas@fittl.com> wrote:
>
> On Wed, Apr 1, 2026 at 7:18 PM John Naylor <johncnaylorls@gmail.com> wrote:
> > +AC_CACHE_CHECK([for __cpuidex], [pgac_cv__cpuidex],
> > +[AC_LINK_IFELSE([AC_LANG_PROGRAM([#ifdef _MSC_VER
> > + #include <intrin.h>
> > + #else
> > + #include <cpuid.h>
> > + #endif],
> > + [[int exx[4] = {0, 0, 0, 0};
> > + __cpuidex(exx, 7, 0);
> > + ]])],
> > + [pgac_cv__cpuidex="yes"],
> > + [pgac_cv__cpuidex="no"])])
> > +if test x"$pgac_cv__cpuidex" = x"yes"; then
> > + AC_DEFINE(HAVE__CPUIDEX, 1, [Define to 1 if you have __cpuidex.])
> > fi
> >
> > MSVC doesn't use autoconf, so we can leave out the intrin.h and keep
> > using unsigned int.
>
> I think that might be a problem for Clang on Windows, which has MSVC
> compatibility headers, and will set _MSC_VER, see [0] and [1].
>
> It probably works in practice, but it seems better to match the
> autoconf checks to the actual code?
Hmm, the previous coding had <intrin.h>, and this is just adding
<cpuid.h> as well, so I left it alone.
The only change I made was to make the #include stanza in pg_cpu_x86.c
match its neighbors.
I thought to add a note to the commit message about the casts to
signed int, but only after pushing did I notice that the explanation
looks out of place since no new code uses __cpuidex yet, and warnings
don't matter for configure checks. Hope it's not too confusing.
--
John Naylor
Amazon Web Services
