Re: [PATCH] Simplify SortSupport implementation for macaddr - Mailing list pgsql-hackers

On Wed, Mar 25, 2026 at 3:01 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Mon, Mar 09, 2026 at 04:08:06PM +0300, Aleksander Alekseev wrote:
> >> 1. The assignment ssup->ssup_extra = NULL can be removed. The
> >>    SortSupport struct is zeroed before the callback is called (see
> >>    sortsupport.h). There are about 22 similar assignments elsewhere;
> >>    it does not seem to be established practice, many other places have
> >>    no such assignment.
> >
> > Agree. I removed this assignment in 0001 and added 0002 that removes
> > if for the rest of *_sortsupport() functions.
>
> Sounds sensible to get rid of the estimation with the Datum size
> requirement and never give up with the abbreviated key sort, as done
> in 0001.  I'd leave the code touched by 0002 remain as-is.

I've committed v2-0001, thanks Aleksander! Without 0002, 0001 made
this code inconsistent with the tree by removing the assignment, so I
left it as in master.

--
John Naylor
Amazon Web Services