Re: centralize CPU feature detection - Mailing list pgsql-hackers

From John Naylor
Subject Re: centralize CPU feature detection
Date
Msg-id CANWCAZa8ffe+moS=VeDVUZ9EyPxz_dBqCFpddQrK+dqMkg4=hg@mail.gmail.com
Whole thread
In response to Re: centralize CPU feature detection  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: centralize CPU feature detection
List pgsql-hackers
On Wed, Feb 25, 2026 at 2:59 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> It appears that if you want to build pg_cpu_x86.o unconditionally,
> you need to make it more proof against the cases it wasn't getting
> built in before.

Thanks, I must have stopped watching the buildfarm too early. I've
pushed a fix which will get undone as part of v6-0002.

On Wed, Feb 25, 2026 at 2:57 AM Zsolt Parragi <zsolt.parragi@percona.com> wrote:
>
> 2 and 3 looks good too, I only found two more typos:
>
>
> + return pg_comp_crc32c(crc, data, len);
> +};
>
> That semicolon is not needed
>
>
> And in the commit message:
>
> "it has been intialized and if"
>
> That should be initialized

Also fixed, thanks.

--
John Naylor
Amazon Web Services

Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: pgsql: libpq: Grease the protocol by default
Next
From: Richard Guo
Date:
Subject: Re: Wrong results with grouping sets