Re: Reduce build times of pg_trgm GIN indexes - Mailing list pgsql-hackers

From John Naylor
Subject Re: Reduce build times of pg_trgm GIN indexes
Date
Msg-id CANWCAZa-AUG=aK7UGGa+NY0sZ2o09Ko=z_N-irkC7Ura_c3uJg@mail.gmail.com
Whole thread
In response to Re: Reduce build times of pg_trgm GIN indexes  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Reduce build times of pg_trgm GIN indexes
List pgsql-hackers
On Tue, Apr 7, 2026 at 6:27 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> But the comments on the pg_cmp functions say:
>
> >  * NB: If the comparator function is inlined, some compilers may produce
> >  * worse code with these helper functions than with code with the
> >  * following form:
> >  *
> >  *     if (a < b)
> >  *         return -1;
> >  *     if (a > b)
> >  *         return 1;
> >  *     return 0;
> >  *
>
> So, uh, is that really a universal improvement? Is that comment about
> producing worse code outdated?

No, it's quite recent:

https://www.postgresql.org/message-id/20240212230423.GA3519%40nathanxps13

--
John Naylor
Amazon Web Services



pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: updates for handling optional argument in system functions
Next
From: Michael Paquier
Date:
Subject: Re: Remove commented-out code in 026_overwrite_contrecord.pl