Re: [HACKERS] Replication slot xmin is not reset if HS feedback isturned off while standby is shut down - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: [HACKERS] Replication slot xmin is not reset if HS feedback isturned off while standby is shut down
Date
Msg-id CANP8+jLx2QwKXAKwXU28sSscfbBHahFM2XTHmS5yDYaCX5S0yw@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Replication slot xmin is not reset if HS feedback isturned off while standby is shut down  (Ants Aasma <ants.aasma@eesti.ee>)
List pgsql-hackers
On 13 January 2017 at 10:17, Ants Aasma <ants.aasma@eesti.ee> wrote:
> On 5 Jan 2017 2:54 a.m., "Craig Ringer" <craig@2ndquadrant.com> wrote:
>> Ants, do you think you'll have a chance to convert your shell script
>> test into a TAP test in src/test/recovery?
>>
>> Simon has said he would like to commit this fix. I'd personally be
>> happier if it had a test to go with it.
>>
>> You could probably just add to src/test/recover/t/001 which now
>> contains my additions for hot standby.
>
> Do you feel the test in the attached patch is enough or would you like
> to see anything else covered?

That looks good, thanks for the patch.

Applying in next few hours, barring objections; then backpatching code
(without tests).

-- 
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: [HACKERS] Allow interrupts on waiting standby
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: [HACKERS] Radix tree for character conversion