Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server - Mailing list pgsql-committers

From Simon Riggs
Subject Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server
Date
Msg-id CANP8+jKoFKXvCZeNUG=TaCtg_YCZp-PDMffO86PG8h=wyF3R0g@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server  (Andres Freund <andres@anarazel.de>)
Responses Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server
List pgsql-committers
On 4 April 2016 at 07:24, Andres Freund <andres@anarazel.de> wrote:
On 2016-04-04 06:19:04 +0000, Simon Riggs wrote:
> Avoid archiving XLOG_RUNNING_XACTS on idle server
>
> If archive_timeout > 0 we should avoid logging XLOG_RUNNING_XACTS if idle.
>
> Bug 13685 reported by Laurence Rowe, investigated in detail by Michael Paquier,
> though this is not his proposed fix.
> 20151016203031.3019.72930@wrigleys.postgresql.org
>
> Simple non-invasive patch to allow later backpatch to 9.4 and 9.5

Uh. This is wrong.

For one it breaks cleanup with logical decoding which
does *NEED* to know that nothing is happening. Although only once, not repeatedly.

If the patch did that, I agree it would be wrong. It doesn't, deliberately.

--
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server