Re: [HACKERS] Failed recovery with new faster 2PC code - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: [HACKERS] Failed recovery with new faster 2PC code
Date
Msg-id CANP8+jJDSSo_7UmBdnGqcdeH+GGbhN5kZWVmqR5sD1tnMgDXsg@mail.gmail.com
Whole thread Raw
In response to [HACKERS] Failed recovery with new faster 2PC code  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: [HACKERS] Failed recovery with new faster 2PC code  (Stas Kelvich <s.kelvich@postgrespro.ru>)
List pgsql-hackers
On 15 April 2017 at 23:37, Jeff Janes <jeff.janes@gmail.com> wrote:
> After this commit, I get crash recovery failures when using prepared
> transactions.
>
> commit 728bd991c3c4389fb39c45dcb0fe57e4a1dccd71
> Author: Simon Riggs <simon@2ndQuadrant.com>
> Date:   Tue Apr 4 15:56:56 2017 -0400
>
>     Speedup 2PC recovery by skipping two phase state files in normal path

Thanks Jeff for your tests.

So that's now two crash bugs in as many days and lack of clarity about
how to fix it.

Stas, I thought this patch was very important to you, yet two releases
in a row we are too-late-and-buggy.

If anybody has a reason why I shouldn't revert this, please say so now
fairly soon.
Any further attempts to fix must run Jeff's tests.

-- 
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: [HACKERS] Variable substitution in psql backtick expansion
Next
From: Stas Kelvich
Date:
Subject: Re: [HACKERS] Failed recovery with new faster 2PC code