change to Docker entrypoint.sh - Mailing list pgadmin-hackers

From Andrew Coleman
Subject change to Docker entrypoint.sh
Date
Msg-id CANNh3aUNwnmYAAzFLL_vt1JRy9TH_TNXRtEHpBVZ9wYVytSdaA@mail.gmail.com
Whole thread Raw
Responses Re: change to Docker entrypoint.sh
List pgadmin-hackers
Hi All!

I am new to this, so I apologize beforehand if it's not entirely kosher, but I have a proposed change to the Dockerfile entrypoint.sh to allow for configurable servers.json filename path.

The reasoning behind this is that I have a Kubernetes deployment of pgadmin where I build a ConfigMap sort of dynamically. I can make the file appear in /pgadmin4, but it removes the contents of the directory for me (helpful!). Instead, I put it into a separate directory and set a new environment variable that defaults to the old pathname (backwards-compatible!) but allows me to set a custom environment variable in my custom Helm chart for my deployment.

The code is here:

Is this something that anyone is interested in?
Does it meet your coding standards?
What do I do next?

I would love to move back to the "official" pgadmin container.

Thanks for your time,

Andrew

pgadmin-hackers by date:

Previous
From: Yosry Muhammad
Date:
Subject: Re: [GSoC][Patch] Automatic Mode Detection V1
Next
From: Dave Page
Date:
Subject: Re: change to Docker entrypoint.sh