Re: MSVC builld of 9.5.12 is broken? - Mailing list pgsql-hackers
From | Sandeep Thakkar |
---|---|
Subject | Re: MSVC builld of 9.5.12 is broken? |
Date | |
Msg-id | CANFyU944Y87YT5N2BDx1q9HQr0dLqoV2aj7NPwyChzxqPsg6pw@mail.gmail.com Whole thread Raw |
In response to | Re: MSVC builld of 9.5.12 is broken? (Magnus Hagander <magnus@hagander.net>) |
List | pgsql-hackers |
Hi Magnus
--
On Tue, Feb 27, 2018 at 6:05 PM, Magnus Hagander <magnus@hagander.net> wrote:
On Tue, Feb 27, 2018 at 11:53 AM, Victor Wagner <vitus@wagner.pp.ru> wrote:On Tue, 27 Feb 2018 11:43:34 +0100
Magnus Hagander <magnus@hagander.net> wrote:
> On Tue, Feb 27, 2018 at 11:27 AM, Victor Wagner <vitus@wagner.pp.ru>
> wrote:
>
> > Hello, hackers.
> >
> > I've tried to build last state of REL9_5_STABLE branch (commit
> > 1f19e46124eee8c6a54834) and under Win32 encountered following
> > errors:
> >
[skip]
>
> It's also interesting to note that this did not break in HEAD, 10 or
> 9.6. And none of those actually have the SCRIPTS_COMMON code.
It seems that it early stages of 9.6 cycle there was another approach
taken to improve readability of this Makefile - just all common code
put into one C file. So there is no need for SCRIPTS_COMMON variable,
because its name is longer than name of common.o which would be its sole
contents.
> I'm unsure why this was introduced in 9.5 and earlier, but not in the
> newer ones. This smells like a possible backpatch mistake, in which
> case that part should probably be backed out of the old branches
> rather than teaching mkvcbuild about it.
Note that said commit (91f3ffc5249) is not limited to rearranging
makefile. It also changes a lot into C code itself. So it is not a
question of reverting commit - it is making new commit, which reverts
changes in just one file.Oh, I missed that.I think we should revert *just the changes to the Makefile*, and of course leave the rest of the comimt. Can you confirm if that fixes the problem?
That fixes some of the errors but the following errors is still seen:
common.obj : error LNK2019: unresolved external symbol _fmtQualifiedId referenced in function _appendQualifiedRelation [D:\pginstaller.auto\postgres.windows\createlang.vcxproj]
common.obj : error LNK2019: unresolved external symbol _appendStringLiteralConn referenced in function _appendQualifiedRelation [D:\pginstaller.auto\postgres.windows\createlang.vcxproj]
.\Release\createlang\createlang.exe : fatal error LNK1120: 2 unresolved externals [D:\pginstaller.auto\postgres.windows\createlang.vcxproj]
"D:\pginstaller.auto\postgres.windows\pgsql.sln" (default target) (1) ->
"D:\pginstaller.auto\postgres.windows\droplang.vcxproj" (default target) (95) ->
common.obj : error LNK2019: unresolved external symbol _fmtQualifiedId referenced in function _appendQualifiedRelation [D:\pginstaller.auto\postgres.windows\droplang.vcxproj]
common.obj : error LNK2019: unresolved external symbol _appendStringLiteralConn referenced in function _appendQualifiedRelation [D:\pginstaller.auto\postgres.windows\droplang.vcxproj]
.\Release\droplang\droplang.exe : fatal error LNK1120: 2 unresolved externals [D:\pginstaller.auto\postgres.windows\droplang.vcxproj]
"D:\pginstaller.auto\postgres.windows\pgsql.sln" (default target) (1) ->
"D:\pginstaller.auto\postgres.windows\pg_isready.vcxproj" (default target) (100) ->
common.obj : error LNK2019: unresolved external symbol _fmtQualifiedId referenced in function _appendQualifiedRelation [D:\pginstaller.auto\postgres.windows\pg_isready.vcxproj]
common.obj : error LNK2019: unresolved external symbol _appendStringLiteralConn referenced in function _appendQualifiedRelation [D:\pginstaller.auto\postgres.windows\pg_isready.vcxproj]
.\Release\pg_isready\pg_isready.exe : fatal error LNK1120: 2 unresolved externals [D:\pginstaller.auto\postgres.windows\pg_isready.vcxproj]
--
--
Sandeep Thakkar
pgsql-hackers by date: