Re: pgstattuple: Use streaming read API in pgstatindex functions - Mailing list pgsql-hackers

From Nazir Bilal Yavuz
Subject Re: pgstattuple: Use streaming read API in pgstatindex functions
Date
Msg-id CAN55FZ3qjh1SKQ9bMg0pZTAbJ2jor4H1JUca=1YXxa8YgVX=-A@mail.gmail.com
Whole thread Raw
In response to Re: pgstattuple: Use streaming read API in pgstatindex functions  (Xuneng Zhou <xunengzhou@gmail.com>)
Responses Re: pgstattuple: Use streaming read API in pgstatindex functions
List pgsql-hackers
Hi,

On Mon, 13 Oct 2025 at 11:42, Xuneng Zhou <xunengzhou@gmail.com> wrote:
>
> Here is patch v3. The comments have been added, and the extra scope
> ({}) has been removed as suggested.

Thanks, the code looks good to me!

The benchmark results are nice. I have a quick question about the
setup, if you are benchmarking with the default io_method (worker),
then the results might show the combined benefit of async I/O and
streaming I/O, rather than just streaming I/O alone. If that is the
case, I would suggest also running a benchmark with io_method=sync to
isolate the performance impact of streaming I/O. You might get
interesting results.

-- 
Regards,
Nazir Bilal Yavuz
Microsoft



pgsql-hackers by date:

Previous
From: wenhui qiu
Date:
Subject: Re: pgstattuple: Use streaming read API in pgstatindex functions
Next
From: John Naylor
Date:
Subject: Re: Reorganize GUC structs