Re: pgindent to ignore build directories - Mailing list pgsql-hackers

From Nazir Bilal Yavuz
Subject Re: pgindent to ignore build directories
Date
Msg-id CAN55FZ2b-0YZv0d5iqMt1PdXY3m9=zTq7KeGVscRpXOfDncTig@mail.gmail.com
Whole thread
In response to Re: pgindent to ignore build directories  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On Thu, 24 Sept 2026 at 17:29, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Peter Eisentraut <peter@eisentraut.org> writes:
> > A subproblem is that if pgindent fails on many files, it doesn't clean
> > up after itself but leaves many pgsrc*.BAK files lying around.  The
> > first patch fixes that.
>
> I object to this patch.  src/tools/pgindent/README documents that
> the presence of those files is useful for detecting where pgindent
> failed.  Without them there's not an easy signal.

I remember being frustrated with too many pgsrc*.BAK files but that
was when pgindent processed the build folder. I think we might not
need 0001 after 0003.

--
Regards,
Nazir Bilal Yavuz
Microsoft



pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: [PATCH] Two remaining shmem attachment issues in single-user mode
Next
From: Trakshan Mishra
Date:
Subject: merge-delete isolation test fails since 85f55534e80