Hi,
Sorry, I didn't notice your reply as it is sent to -hackers list only.
Thank you for looking into this!
On Fri, 3 Jul 2026 at 00:50, Zsolt Parragi <zsolt.parragi@percona.com> wrote:
>
> Everything seems to be properly working with the new version in my
> tests, I only have a few minor comments:
>
> + <para>
> + When <productname>PostgreSQL</productname> is built with
> + <productname>Meson</productname>, it installs a
> + <literal>pkg-config</literal> file named
> + <literal>postgresql-&majorversion;-llvm-jit-bitcode.pc</literal>. It is
> + used internally to emit <acronym>LLVM</acronym> <acronym>JIT</acronym>
> + bitcode for the server and for selected
> + <filename>contrib</filename> modules, and it collects the same
> + compilation flags that are used to build the server itself.
> + </para>
>
> Do we want to install these pc files even with -Dllvm=disabled?
I think we want to install them as these pc files can be used for
building extensions.
> diff --git a/src/tools/irlink b/src/tools/irlink
> new file mode 100644
> index 00000000000..6a03e4f5695
> --- /dev/null
> +++ b/src/tools/irlink
>
> Shouldn't this file committed as executable?
Yes, done.
> +import shutil
> +import subprocess
> +import sys
>
> Is shutil and sys used in the script?
They are not used, removed.
v14 is attached.
--
Regards,
Nazir Bilal Yavuz
Microsoft
