Re: make -C src/test/isolation failure in index-killtuples due to btree_gist - Mailing list pgsql-hackers

From Nazir Bilal Yavuz
Subject Re: make -C src/test/isolation failure in index-killtuples due to btree_gist
Date
Msg-id CAN55FZ25NO86hpRoZ+vNNpzLU=7TBPg+i92qj+y16Dx0ZhBtig@mail.gmail.com
Whole thread Raw
In response to Re: make -C src/test/isolation failure in index-killtuples due to btree_gist  (Michael Paquier <michael@paquier.xyz>)
Responses Re: make -C src/test/isolation failure in index-killtuples due to btree_gist
List pgsql-hackers
Hi,

On Fri, 31 Oct 2025 at 03:42, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Oct 30, 2025 at 11:24:55AM -0400, Andres Freund wrote:
> > Well, it tests multiple index types, not just gist. I guess
> > test/modules/indexes/ or so should work? Not sure about plural or not.
>
> test/modules/index/ would work here.  If you feel strongly about being
> able to do an EXTRA_INSTALL in src/test/isolation/, I have no
> objections to that as that would also solve the original problem if
> that's the consensus.  My personal choice would be a test module for
> that, as it feels cleaner.

I have two patches to implement this: one moving the killtuples test
under test/modules/index/, and another adding coverage for the
recovery path.

0001 moves killtuples test under the test/modules/index/ without any
implementation change.

0002 converts the killtuples isolation test to a TAP test to exercise
the recovery path. This patch sets up a standby and additionally
re-inserts into the table while testing the GiST index to ensure
coverage of the gistRedoDeleteRecord() function.

-- 
Regards,
Nazir Bilal Yavuz
Microsoft

Attachment

pgsql-hackers by date:

Previous
From: Ilia Evdokimov
Date:
Subject: Re: Use merge-based matching for MCVs in eqjoinsel
Next
From: Heikki Linnakangas
Date:
Subject: Re: POC: make mxidoff 64 bits