Re: Building with meson on NixOS/nixpkgs - Mailing list pgsql-hackers

From Nazir Bilal Yavuz
Subject Re: Building with meson on NixOS/nixpkgs
Date
Msg-id CAN55FZ20xWGdj1KnQJ20TsnXHy2Tgbxmp82Ci8RvHktOyJ_GSw@mail.gmail.com
Whole thread Raw
In response to Building with meson on NixOS/nixpkgs  (Wolfgang Walther <walther@technowledgy.de>)
Responses Re: Building with meson on NixOS/nixpkgs
List pgsql-hackers
Hi,

Thank you for the patches!

On Sat, 16 Mar 2024 at 14:48, Wolfgang Walther <walther@technowledgy.de> wrote:
>
> To build on NixOS/nixpkgs I came up with a few small patches to
> meson.build. All of this works fine with Autoconf/Make already.

I do not have NixOS but I confirm that patches cleanly apply to master
and do pass CI. I have a small feedback:

0001 & 0002: Adding code comments to explain why they have fallback
could be nice.
0003: Looks good to me.

-- 
Regards,
Nazir Bilal Yavuz
Microsoft



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Reducing connection overhead in pg_upgrade compat check phase
Next
From: Robert Haas
Date:
Subject: Re: Possibility to disable `ALTER SYSTEM`