On Fri, 17 Oct 2025 at 15:31, Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 17 Oct 2025, at 14:25, Álvaro Herrera <alvherre@kurilemu.de> wrote:
> >
> > On 2025-Oct-17, Nazir Bilal Yavuz wrote:
> >
> >> first=1
> >> -for corefile in $(find "$directory" -type f) ; do
> >> +# minfree is not a core file but may exists in the crash directory, skip it
> >> +for corefile in $(find "$directory" -type f -not -name "minfree") ; do
> >> if [ "$first" -eq 1 ]; then
> >> first=0
> >> else
> >
> > This looks quite random. Why not do "find ... -name '*core*'" instead?
> > I mean, if we have minfree there today, we could have maxbusy tomorrow
> > or whatever.
>
> I think we should be able to count of the core directory on controlled CI
> instances not being cluttered with random files - if it is we probably want a
> test failure logged so we can look at it - but minfree is a special file for
> core dump handling on some platforms so skipping that make sense I think.
I agree with both. How about moving "minfree" to a variable
(presumably an array); instead of having a hard coded string? So that
we can exclude all files in this variable.
--
Regards,
Nazir Bilal Yavuz
Microsoft
