Hi,
Thank you for working on this!
On Mon, 13 Oct 2025 at 06:20, Xuneng Zhou <xunengzhou@gmail.com> wrote:
>
> Fix indentation issue in v1.
I did not look at the benchmarks, so here are my code comments.
- I would avoid creating a new scope for the streaming read. While it
makes the streaming code easier to interpret, it introduces a large
diff due to indentation changes.
- I suggest adding the following comment about streaming batching, as
it is used in other places:
/*
* It is safe to use batchmode as block_range_read_stream_cb takes no
* locks.
*/
- For the '/* Scan all blocks except the metapage using streaming
reads */' comments, it might be helpful to clarify that the 0th page
is the metapage. Something like: '/* Scan all blocks except the
metapage (0th page) using streaming reads */'.
Other than these comments, the code looks good to me.
--
Regards,
Nazir Bilal Yavuz
Microsoft
