Re: ci: Skip minfree file in the cores_backtrace.sh - Mailing list pgsql-hackers

From Nazir Bilal Yavuz
Subject Re: ci: Skip minfree file in the cores_backtrace.sh
Date
Msg-id CAN55FZ0jLgf-S8FXehytHaxNXnnRQ_9WNLmN48av8vgg69bhKQ@mail.gmail.com
Whole thread Raw
In response to Re: ci: Skip minfree file in the cores_backtrace.sh  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Hi,

This problem is still happening.

On Fri, 17 Oct 2025 at 15:31, Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 17 Oct 2025, at 14:25, Álvaro Herrera <alvherre@kurilemu.de> wrote:
> >
> > On 2025-Oct-17, Nazir Bilal Yavuz wrote:
> >
> >> first=1
> >> -for corefile in $(find "$directory" -type f) ; do
> >> +# minfree is not a core file but may exists in the crash directory, skip it
> >> +for corefile in $(find "$directory" -type f -not -name "minfree") ; do
> >>     if [ "$first" -eq 1 ]; then
> >>         first=0
> >>     else
> >
> > This looks quite random.  Why not do "find ... -name '*core*'" instead?
> > I mean, if we have minfree there today, we could have maxbusy tomorrow
> > or whatever.
>
> I think we should be able to count of the core directory on controlled CI
> instances not being cluttered with random files - if it is we probably want a
> test failure logged so we can look at it - but minfree is a special file for
> core dump handling on some platforms so skipping that make sense I think.

I see that we already search for *core* string in the
cores_backtrace.sh script (we do it only for OpenBSD but I think it
doesn't matter):

```
base=$(echo "$filename" | sed 's/\.core.*$//')
```

So, I wanted to continue with Álvaro's suggestion. v2 is attached.

Example CI run: https://cirrus-ci.com/build/6447813132812288


--
Regards,
Nazir Bilal Yavuz
Microsoft

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Automatically sizing the IO worker pool
Next
From: Alvaro Herrera
Date:
Subject: Re: Adding REPACK [concurrently]