Hi,
Thank you for looking into this!
On Wed, 15 Oct 2025 at 21:32, Peter Eisentraut <peter@eisentraut.org> wrote:
>
> On 07.10.25 15:12, Nazir Bilal Yavuz wrote:
> > 1 - A new sgml_syntax_check.pl script was added to handle tab, nbsp,
> > and xmllint validation checks.
> > 1.1 - It is registered as the sgml_syntax_check test in the Meson build.
> > 1.2 - These checks are run when executing 'make check' or 'meson test
> > sgml_syntax_check' commands.
> > 1.3 - During the creation of postgres-full.xml, the script performs
> > tab and nbsp checks. The xmllint check is skipped there, since
> > validation is already handled by the --valid option. So, we do not run
> > the same check twice.
>
> I think including the xmllint support in the new sgml_syntax_check is
> overkill, since the normal build already runs xmllint, or you could
> alternatively just write it into the build description file (makefile or
> meson.build). The build commands should be visible in the build
> description file, not layered into some other script.
>
> I suggest the following approach:
>
> - Change sgml_syntax_check.pl into a smaller script that just checks for
> tabs and nbsp. (Maybe a different name then.)
>
> - Add a call of that script to the build of postgres-full.xml.
>
> - Change the "check" target to just depend on postgres-full.xml, without
> its own commands.
>
> And then replicate that logic in meson.
All of these are addressed in v7. I think sgml_syntax_check is still a
suitable name but I am open to suggestions.
--
Regards,
Nazir Bilal Yavuz
Microsoft
