Request a Demo
Home   >   mailing lists

Re: Stack-based tracking of per-node WAL/buffer usage - Mailing list pgsql-hackers

From Zsolt Parragi
Subject Re: Stack-based tracking of per-node WAL/buffer usage
Date
Msg-id CAN4CZFPJOG0PeLOBmZZvkY+aeZJ0+swjNjUabaeeimWxbtN41A@mail.gmail.com
Whole thread Raw
In response to Re: Stack-based tracking of per-node WAL/buffer usage  (Lukas Fittl <lukas@fittl.com>)
Responses Re: Stack-based tracking of per-node WAL/buffer usage
List pgsql-hackers
Tree view 
I like the new approach, but doesn't `EXPLAIN (BUFFERS)` leak some
memory because the resource owner isn't registered on that path? It
seems to be visible with pg_log_backend_memory_contexts.

 #define INSTR_BUFUSAGE_ADD(fld,val) do { \
- pgBufferUsage.fld += val; \
+ instr_stack.current->bufusage.fld += val; \

 #define INSTR_WALUSAGE_ADD(fld,val) do { \
  pgWalUsage.fld += val; \
+ instr_stack.current->walusage.fld += val; \

Nitpick, but these could use += (val)

pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: [19] CREATE SUBSCRIPTION ... SERVER
Next
From: Jeff Davis
Date:
Subject: Re: Use CASEFOLD() internally rather than LOWER()