> I believe this is now a complete patch
> proposal; tear it apart. :D
The patch looks good to me as is, I don't see any real issues with it,
maybe one cosmetic question in the test.
+ if (GetOAuthHBAOption(state, "log"))
+ elog(LOG, "%s", GetOAuthHBAOption(state, "log"));
+
If we treat the test code as an example for real implementations, this
and the other use could cache the option in a local variable instead
of making duplicate calls, following the pattern of the documentation.
