Re: Do we want to solve reload/config races more generally? (was: Postmaster crashes on SIGHUP when oauth_validator_libraries holds only whitespace) - Mailing list pgsql-hackers

From Zsolt Parragi
Subject Re: Do we want to solve reload/config races more generally? (was: Postmaster crashes on SIGHUP when oauth_validator_libraries holds only whitespace)
Date
Msg-id CAN4CZFP7ZMLB5Q1P4H__2d54om6fO+OEBZpWLpMwhFipobrEEw@mail.gmail.com
Whole thread
In response to Re: Do we want to solve reload/config races more generally? (was: Postmaster crashes on SIGHUP when oauth_validator_libraries holds only whitespace)  (Andrey Borodin <x4mmm@yandex-team.ru>)
List pgsql-hackers
Hello

There's still a leftover empty validator issue, even if not that
serious: '""'. It returns a list with a single empty string, so the
new check doesn't catch it, the hba line gets a single empty named
validator.

This hits an assertion in debug builds, but otherwise works mostly
fine in release builds with a 'could not access file ""' error.

The attached patch adds an additional check for this.

Attachment

pgsql-hackers by date:

Previous
From: Xuneng Zhou
Date:
Subject: Re: Deadlock detector fails to activate on a hot standby replica
Next
From: Zsolt Parragi
Date:
Subject: Emptying oauth_validator_libraries doesn't stop OAuth logins