Re: Improve OAuth discovery logging - Mailing list pgsql-hackers

From Zsolt Parragi
Subject Re: Improve OAuth discovery logging
Date
Msg-id CAN4CZFP--Ec8hMgpu7JojgK9qS08bNnev0c6goA++T4Ozy8bOQ@mail.gmail.com
Whole thread Raw
In response to Re: Improve OAuth discovery logging  (Jacob Champion <jacob.champion@enterprisedb.com>)
Responses Re: Improve OAuth discovery logging
List pgsql-hackers
> I don't
> want to escape the authentication flow from inside a SASL mech, though
> (it's unusual/invisible to other maintainers, plus it bypasses the
> ClientAuthentication_hook).

I tried to figure out if this is fine or not, but isn't it the same as
the existing ereport(ERROR, ...) calls everywhere in the sasl/scram
code? I didn't see any clear pattern, for example the LDAP code
clearly uses

ereport(LOG, ...);
return STATUS_ERROR;

 even for internal/configuration errors, while the scram/sasl code
uses ereport(ERROR, ...) for those errors.



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: pg_restore --format= option(without any value) should report an error as pg_dump is reporting an error
Next
From: Jeff Davis
Date:
Subject: Re: Expanding HOT updates for expression and partial indexes