Request a Demo
Home   >   mailing lists

Re: Patch: dumping tables data in multiple chunks in pg_dump - Mailing list pgsql-hackers

From Zsolt Parragi
Subject Re: Patch: dumping tables data in multiple chunks in pg_dump
Date
Msg-id CAN4CZFOTOX1nFkPrmM7fQ9qnrccvjwywXPf4Eo7C+DF-h-x96g@mail.gmail.com
Whole thread Raw
In response to Re: Patch: dumping tables data in multiple chunks in pg_dump  (Hannu Krosing <hannuk@google.com>)
Responses Re: Patch: dumping tables data in multiple chunks in pg_dump
List pgsql-hackers
Tree view 
Hello

pgdump.c:7174

+ appendPQExpBufferStr(query, "pg_relation_size(c.tableoid)/8192 AS
relpages, ");

Shouldn't this be something like

+ appendPQExpBufferStr(query,
"pg_relation_size(c.oid)/current_setting('block_size')::int AS
relpages, ");

instead?

pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: anonymous unions (C11)
Next
From: Zsolt Parragi
Date:
Subject: Re: Proposal: Adding compression of temporary files