Re: centralize CPU feature detection - Mailing list pgsql-hackers

From Zsolt Parragi
Subject Re: centralize CPU feature detection
Date
Msg-id CAN4CZFNpt2tsysM5j8GvhOLqU2fKiPEGW7xGJ987_Avwk7-7ag@mail.gmail.com
Whole thread Raw
In response to centralize CPU feature detection  (John Naylor <johncnaylorls@gmail.com>)
Responses Re: centralize CPU feature detection
List pgsql-hackers
Hello!

Seems like a file (checksum_block_internal.h) is missing from the patch?

For the entire src/include/port/pg_x86_feature.h:

Shouldn't it have an

+#if defined(USE_SSE2) || defined(__i386__)
...
#endif

block around the file, to skip everything on other platforms?

In src/include/port/pg_x86_feature.h:33

+
+extern PGDLLEXPORT bool X86Feature[];
+

Shouldn't that be PGDLLIMPORT?

+typedef enum X86FeatureId
+{
+ init,
+
+ PG_SSE4_2,
+ PG_POPCNT,


Shouldn't that be INIT?



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Fix uninitialized xl_running_xacts padding
Next
From: Andrew Dunstan
Date:
Subject: Re: generating function default settings from pg_proc.dat