Re: Improve OAuth discovery logging - Mailing list pgsql-hackers

From Zsolt Parragi
Subject Re: Improve OAuth discovery logging
Date
Msg-id CAN4CZFNWBXtF-ML3yzdOvX3QEuUwVo5VrBzyWU3O=y-7SeDstA@mail.gmail.com
Whole thread
In response to Re: Improve OAuth discovery logging  (Jacob Champion <jacob.champion@enterprisedb.com>)
Responses Re: Improve OAuth discovery logging
Re: Improve OAuth discovery logging
List pgsql-hackers
> "ctx->state = OAUTH_STATE_FINISHED;" is duplicated in the “if” and after the “if”, so it can be pull up to before the
“if”.

It can't, because the if is based on ctx->state. If I move it to
before the if, I have to save the previous value, which just makes the
code longer.

I attached v4 with an edited commit message, nothing else changed.

Commitfest: https://commitfest.postgresql.org/patch/6529/

Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: pg_basebackup: removed an unnecessary use of memset in FindStreamingStart
Next
From: Andrey Borodin
Date:
Subject: Re: Fix XLogFileReadAnyTLI silently applying divergent WAL from wrong timeline