Re: pg_hosts: Add pg_hosts_file_rules() - Mailing list pgsql-hackers

From Zsolt Parragi
Subject Re: pg_hosts: Add pg_hosts_file_rules()
Date
Msg-id CAN4CZFNQR4Nd2+LGfeuwfkunwGuNS5nZbv-GRxResntSkqx72g@mail.gmail.com
Whole thread
Responses Re: pg_hosts: Add pg_hosts_file_rules()
Re: pg_hosts: Add pg_hosts_file_rules()
List pgsql-hackers
> If you can find a good way to do it without convoluting the testfile which
> currently just does a skip_all in case of LibreSSL, then why not.  If it reduce
> readability of the test file then it's probably not worth it since it's not
> using any different codepaths from the OpenSSL counterpart.

Done. I added an if with an early exit instead of the skip, it seems
to work properly with a local LibreSSL build I tested and I think it
looks okay.

> It also makes more sense to me to first test parsing, and then parsing+loading.

Also done. I also modified the test to use a connection string so that
I don't have to add a trust entry to pg_hba before the connection
tests.

Attachment

pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: Why clearing the VM doesn't require registering vm buffer in wal record
Next
From: Tom Lane
Date:
Subject: Re: Small patch to improve safety of utf8_to_unicode().