Re: SSI: ON CONFLICT DO SELECT takes no predicate lock on the returned row - Mailing list pgsql-hackers

From Zsolt Parragi
Subject Re: SSI: ON CONFLICT DO SELECT takes no predicate lock on the returned row
Date
Msg-id CAN4CZFNHExB699FKRpWwyXEox7B7TNXPvFWzWaF=jKjUe_KQfQ@mail.gmail.com
Whole thread
In response to Re: SSI: ON CONFLICT DO SELECT takes no predicate lock on the returned row  (Dean Rasheed <dean.a.rasheed@gmail.com>)
List pgsql-hackers
On Mon, 07 Sep 2026, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
> However, that fix seems to have the same kind of layering
> violation that Andres complained about for the first version of the
> patch on this thread -- predicate locking should be in heapam code,
> not in execIndexing.c.

It's not just the layering violation, that solution also has a
leftover issue, similarly to my first patch in this thread. When I
looked at this my initial conclusion was that we can't fix the two at
the same place without layering violations / remaining issues, so my
idea was to apply the same fix as I did for SELECT to those paths, but
I'll take another look at it.



Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Crashes on a partition whose concurrent detach never finished
Next
From: Ilia Evdokimov
Date:
Subject: Re: COALESCE patch