Re: Make PGOAUTHCAFILE in libpq-oauth work out of debug mode - Mailing list pgsql-hackers

From Zsolt Parragi
Subject Re: Make PGOAUTHCAFILE in libpq-oauth work out of debug mode
Date
Msg-id CAN4CZFMtcRDBQACw==1aHRBmdQDWNz=v4RqY0--iF=G6QfiQ3A@mail.gmail.com
Whole thread
In response to Re: Make PGOAUTHCAFILE in libpq-oauth work out of debug mode  ("Jonathan Gonzalez V." <jonathan.abdiel@gmail.com>)
Responses Re: Make PGOAUTHCAFILE in libpq-oauth work out of debug mode
List pgsql-hackers
Hello

I only have a few minor comments/questions:

Shouldn't we free oauth_ca_file in freePGconn?

Would a test case with an invalid/incorrect CA file be also useful, or
is that too much testing of curl internals?

diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
index 6db823808fc..24fda826dd1 100644
--- a/doc/src/sgml/libpq.sgml
+++ b/doc/src/sgml/libpq.sgml

Shouldn't the doc update also include oauth_ca_file?

+ {"oauth_ca_file", "PGOAUTHCAFILE", NULL, NULL,
+ "Oauth-CA-File", "", 64,
+ offsetof(struct pg_conn, oauth_ca_file)}

That should be OAuth-CA-File

+ * Allow to set the CA even if we're not in debug mode, this would make it easy
+ * to work on environments were the CA could be internal and available on every
+ * system, like big companies with airgap systems.

where the CA



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: index prefetching
Next
From: Andres Freund
Date:
Subject: Re: index prefetching