Re: basebackup: do not verify checksums on pages written before enabling checksums - Mailing list pgsql-hackers

From Zsolt Parragi
Subject Re: basebackup: do not verify checksums on pages written before enabling checksums
Date
Msg-id CAN4CZFMq5x+kJBYvT5ezz4MLXTQg=wEGtu2JtPOpc3ui_7s9fQ@mail.gmail.com
Whole thread
In response to Re: basebackup: do not verify checksums on pages written before enabling checksums  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
Responses Re: basebackup: do not verify checksums on pages written before enabling checksums
List pgsql-hackers
> The failure is triggered at the end of perform_base_backup() when total_checksum_failures equals 1,
> via ereport(ERROR, errcode(XX001)).
> However, pg_stat_database.checksum_failures is not updated at all.

This seems like a separate issue existing for much longer, I'll submit
a separate patch about it.

> Judging by the current test cases,,
> pg_stat_database.checksum_failures appears to offer no detection capability beyond what ok($backup->finish) already
provides.

I improved the tests a bit, while also adding the 32m shared buffers
change to 010. I kept this as a separate commit for easier review.

Attachment

pgsql-hackers by date:

Previous
From: Matthias van de Meent
Date:
Subject: Re: Logical replication row filter loses unchanged toasted columns
Next
From: Bertrand Drouvot
Date:
Subject: Re: basebackup: do not verify checksums on pages written before enabling checksums