Re: table AM option passing - Mailing list pgsql-hackers

From Zsolt Parragi
Subject Re: table AM option passing
Date
Msg-id CAN4CZFMbxsZ2hjBsGZ4Ex3kmD6--mXsM4hSLn-dMzHLT8XN-Pw@mail.gmail.com
Whole thread
In response to Re: table AM option passing  (Álvaro Herrera <alvherre@kurilemu.de>)
List pgsql-hackers
 static inline TM_Result
 table_tuple_delete(Relation rel, ItemPointer tid, CommandId cid,
-    Snapshot snapshot, Snapshot crosscheck, bool wait,
-    TM_FailureData *tmfd, bool changingPart)
+    uint32 options, Snapshot snapshot, Snapshot crosscheck,
+    bool wait, TM_FailureData *tmfd)

The doc comment still referneces changingPart
Similarly table_tuple_update doesn't document the new options parameter.

@@ -339,7 +341,8 @@ heapam_tuple_update(Relation relation, ItemPointer
otid, TupleTableSlot *slot,
  slot->tts_tableOid = RelationGetRelid(relation);
  tuple->t_tableOid = slot->tts_tableOid;

- result = heap_update(relation, otid, tuple, cid, crosscheck, wait,
+ result = heap_update(relation, otid, tuple, cid, options,
+ crosscheck, wait,
  tmfd, lockmode, update_indexes);
  ItemPointerCopy(&tuple->t_self, &slot->tts_tid);

options is marked pg_attribute_unused above, that seems misleading.
Should the annotation be part of the heap_update signature instead?



pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)
Next
From: Roberto Mello
Date:
Subject: Re: pg_publication_tables: return NULL attnames when no column list is specified