On Thu, 24 Sep 2026, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> So if we want to
> use the condition variable, it seems better to me to have a dedicated
> wait function in vacuumparallel.c that waits until all indexes are
> completed, and then call WaitForParallelWorkersToFinish().
That'll bring back the more complicated approach of v2, and also make
this part of the code more complex.
While I didn't do proper measurements, my logic against it was similar
to what Manu already posted, that it seems harmless here and it is
significantly simpler than adding a cv.
Also, I think both issues could be solved in a more proper way with
more refactoring, but that seems excessive for 19. (And in that case,
going with a simple solution for 19 also seems like a good answer to
me)
