Request a Demo
Home   >   mailing lists

Re: [PATCH] Rebuild CHECK constraints after generated column SET EXPRESSION - Mailing list pgsql-hackers

From Zsolt Parragi
Subject Re: [PATCH] Rebuild CHECK constraints after generated column SET EXPRESSION
Date
Msg-id CAN4CZFMHmb=o_GkJrgEY1iEQpnuDtL_YEHKFZNWG0bdZyozXvA@mail.gmail.com
Whole thread
Responses Re: [PATCH] Rebuild CHECK constraints after generated column SET EXPRESSION
List pgsql-hackers
Tree view 
Looks good, I have one nitpick question:

+            if (isnull)
+                elog(WARNING, "null conbin for relation \"%s\"",
+                     RelationGetRelationName(rel));

Shouldn't this be an error instead? Most existing checks treat it as
an error, and that seems better to me as this shouldn't happen
normally?

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Fix bug of CHECK constraint enforceability recursion
Next
From: Michael Paquier
Date:
Subject: Re: injection_points: Switch wait/wakeup to use atomics rather than latches