Re: WIP - xmlvalidate implementation from TODO list - Mailing list pgsql-hackers

From Marcos Magueta
Subject Re: WIP - xmlvalidate implementation from TODO list
Date
Msg-id CAN3aFCcb0Nvap1CKShd5RNa+V+pray+ur_LtOON3nkwqdh5NMA@mail.gmail.com
Whole thread Raw
In response to Re: WIP - xmlvalidate implementation from TODO list  (Marcos Magueta <maguetamarcos@gmail.com>)
Responses Re: WIP - xmlvalidate implementation from TODO list
List pgsql-hackers
Hey Jim,

I finally got back to it.

> On second thought, is there any scenario where we'll need a_expr for "y"
> at all in "CREATE XMLSCHEMA x AS y"? Isn't it always going to be a
> string? I see now that my example in the previous post was somewhat
> misleading (sorry for the noise).
I think you are right about removing the alias here, but I thought that on the previous exchange you were referring to the expression on x, not y. Nonetheless I see no point in keeping aliases here, however. I added it because I initially thought of aliasing chained expressions, but that makes little sense in an effectful command.

> I'd suggest to focus on 0001 for now. Feel free to revert it to the
> state of v4 if you disagree with the current approach.
I am perfectly fine with the split, I think splitting it further will cause more problems to review because of their interdependency as you pointed out.

It seems that for v6, all that is left is to revise the grant for read and write, and add the docs. Correct?

If so, I will get started with it.

Regards!

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Interrupts vs signals
Next
From: Jim Jones
Date:
Subject: Re: WIP - xmlvalidate implementation from TODO list