Re: parallel autovacuum: Propagate track_cost_delay_timing to parallel workers - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: parallel autovacuum: Propagate track_cost_delay_timing to parallel workers
Date
Msg-id CAN12+YKdOimN3dXwU7AffJ1R-4No62vQfNBZvvcofbkO_2BAGQ@mail.gmail.com
Whole thread
In response to Re: parallel autovacuum: Propagate track_cost_delay_timing to parallel workers  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Hi,

> That said, I checked track_wal_io_timing and it reports the
> accumulated timing even after the GUC is turned off, see
> pgstat_count_io_op_time(). IIUC, what matters there is whether timing
> was on when the start time was captured, not what it is at reporting
> time. Looking at that, I would prefer reporting the remaining
> accumulated time here too to make it complete.

Fair enough.

I guess this also fits better with the existing comment.

```
/* Report any remaining cost-based vacuum delay time */
```

> Also, +1 to rename track_delay_timing to GUC name.

Done.

v2 attached.

--
Sami

Attachment

pgsql-hackers by date:

Previous
From: Denis Smirnov
Date:
Subject: Re: Fold NOT IN / <> ALL expressions containing NULL to FALSE
Next
From: "Tristan Partin"
Date:
Subject: Re: Add counted_by attribute