Thanks!
> I wonder why in your fix we keep a pointer to the whole relation instead
> of just to its tupledesc. What about the attached v4?
It was expedient. The tupledesc is all we need, so v4 is better. This LGTM.
> I ran your test with only CreateTupleDescCopy() to see how would your new
> test would fail (because such a descriptor wouldn't have the missing
> attrs), but it failed differently, because attnotnull is not set.
> Anyway, this was just a perhaps pointless experiment.
Thanks for checking. Right, CreateTupleDescCopy() would just reintroduce
the problem we're fixing.
v5 attached fixes indentation.
--
Sami Imseih
Amazon Web Services (AWS)
