Re: parallel autovacuum: Propagate track_cost_delay_timing to parallel workers - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: parallel autovacuum: Propagate track_cost_delay_timing to parallel workers
Date
Msg-id CAN12+YJA2dcL2aPD0vwEsJML8Ue3=auSH8Q30J01n9W+4Vfq2g@mail.gmail.com
Whole thread
In response to Re: parallel autovacuum: Propagate track_cost_delay_timing to parallel workers  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
> > track_cost_delay_timing gates delay timing reporting elsewhere, so we should not
> > deviate from that. If the GUC is off by then, we should not accumulate
> > any timing
> > anyhow, even if parallel_vacuum_worker_delay_ns > 0
>
> IIUC the remaining parallel_vacuum_worker_delay_ns was accumulated
> when the track_cost_delay_timing was enabled. Shouldn't we report it
> as well?

We could swap
```
/* Report any remaining cost-based vacuum delay time */
if (track_cost_delay_timing)
```

with

```
/* Report any remaining cost-based vacuum delay time */
if (parallel_vacuum_worker_delay_ns)
```

but I did not think that made sense. When we get to the point of reporting
the remaining time, and the track_cost_delay_timing is disabled, then
I don't think we should report anything.

--
Sami



pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: create table like including storage parameter
Next
From: Amit Kapila
Date:
Subject: Re: Fix "unexpected logical decoding status change" error; from concurrent logical decoding activation