Postgres Pro
Downloads
Home   >   mailing lists

Re: WIP: System Versioned Temporal Table - Mailing list pgsql-hackers

From Ryan Lambert
Subject Re: WIP: System Versioned Temporal Table
Date
Msg-id CAN-V+g_ZpK7cbx7szKV8Ma6sNNGy4d34sGh5FMy14h68F8gjBQ@mail.gmail.com
Whole thread Raw
In response to Re: WIP: System Versioned Temporal Table  (Surafel Temesgen <surafel3000@gmail.com>)
Responses Re: WIP: System Versioned Temporal Table
List pgsql-hackers
Tree view
On Thu, Nov 19, 2020 at 11:04 AM Surafel Temesgen <surafel3000@gmail.com> wrote:

Attached is a rebased one.
regards
Surafel

Thank you for your work on this!  The v7 patch fails on the current master branch.  Error from make:

gram.y:16695:1: error: static declaration of ‘makeAndExpr’ follows non-static declaration
 makeAndExpr(Node *lexpr, Node *rexpr, int location)
 ^~~~~~~~~~~
In file included from gram.y:58:0:
../../../src/include/nodes/makefuncs.h:108:14: note: previous declaration of ‘makeAndExpr’ was here
 extern Node *makeAndExpr(Node *lexpr, Node *rexpr, int location);
              ^~~~~~~~~~~
gram.y:16695:1: warning: ‘makeAndExpr’ defined but not used [-Wunused-function]
 makeAndExpr(Node *lexpr, Node *rexpr, int location)
 ^~~~~~~~~~~


The docs have two instances of "EndtTime" that should be "EndTime". 

Ryan Lambert

pgsql-hackers by date:

Previous
From: Pavel Borisov
Date:
Subject: Re: [PATCH] Automatic HASH and LIST partition creation
Next
From: Dmitry Dolgov
Date:
Subject: Re: [HACKERS] [PATCH] Generic type subscripting